-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMP]split minimize and add unscale_ for GradScaler #35825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
zhangbo9674
changed the title
Dev/split minimize and unscale
[AMP]split minimize and unscale
Sep 17, 2021
zhangbo9674
changed the title
[AMP]split minimize and unscale
[AMP]split minimize and add unscale_ for GradScaler
Sep 22, 2021
zhiqiu
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TCChenlong
approved these changes
Sep 22, 2021
lanxianghit
approved these changes
Sep 22, 2021
zhangbo9674
added a commit
to zhangbo9674/Paddle
that referenced
this pull request
Sep 22, 2021
* split minimize() to step() + update() * add unscale and step for grad_scaler * add unittest * refine code in minimize * delete step in loss_scaler * fix example bug * refine comment * refine unittest * add unittest
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* split minimize() to step() + update() * add unscale and step for grad_scaler * add unittest * refine code in minimize * delete step in loss_scaler * fix example bug * refine comment * refine unittest * add unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
1、Split function
GradScaler::minimize()
toGradScaler::step()
+GradScaler::update()
:GradScaler::minimize()
:GradScaler::step()
+GradScaler::update()
:minimize()
andstep()
+update()
are two methods of parameter gradient updating in amp. In paddle 2.0, we recommend usingstep()
+update()
.If optimizer belongs to paddle 1.0, only
minimize()
can be used.2、Add
GradScaler::unscale_(optimizer)
:unscale_
is not called,minimize()
orstep()
will call this api, else this call will not be repeated.3、docs review:
GradScaler:
step+update:
unscale_:
中文文档pr链接:
PaddlePaddle/docs#3897