Add more tests and fix bugs for cudnn_norm_conv_test and cudnn_bn_and_relu_test #36314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ZzSean
force-pushed
the
cudnn_fusion_test
branch
from
88bcb60
to
2c75558
Compare
Xreki
approved these changes
Oct 11, 2021
| @@ -369,10 +381,25 @@ class CudnnNormConvolutionTester { | |||
| TensorCopySync(filter_grad, platform::CPUPlace(), cpu_filter_grad); | |||
| } | |||
|
|
|||
| bool Support(const platform::CUDADeviceContext &ctx) { | |||
| if ((kernel_size_ == 3) || ((kernel_size_ == 1) && (stride_ == 1))) { | ||
| return true; | ||
| } | ||
| } else if (ctx.GetComputeCapability() > 70) { |
There was a problem hiding this comment.
这里可能用>=80比较好，因为还有75计算能力的GPU卡，不确定是否支持呢。文档中怎么说？另外，这个到底是跟GPU型号有关，还是跟cudnn版本有关呢？
这个检查建议挪到CudnnNormConvolution的实现里面，并且加一些注释。
ZzSean
changed the title
ZzSean
changed the title
Xreki
changed the title
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
为cudnn_fusion_op增加了单测，更早PR见：
#35557
#35955
#36168
其中：