Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adaptiveLogsoftmaxwithloss #36326

Closed

Conversation

GuoQuanhao
Copy link

@GuoQuanhao GuoQuanhao commented Oct 11, 2021

PR types

New features

PR changes

APIs

Describe

add adaptiveLogsoftmaxwithloss

the demo repo ref https://github.com/GuoQuanhao/AdaptiveLogSoftmaxWithLoss-Paddle or https://aistudio.baidu.com/aistudio/projectdetail/2453090?shared=1

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 11, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@zhiboniu zhiboniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请补充单测和文档吧

@@ -49,6 +49,7 @@
from .layer.activation import ThresholdedReLU # noqa: F401
from .layer.activation import LogSoftmax # noqa: F401
from .layer.activation import Maxout # noqa: F401
from .layer.adaptive import AdaptiveLogSoftmaxWithLoss # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要添加到 __all__ 中

@@ -0,0 +1,291 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、新增功能添加到 loss.py 文件中
2、需要补充单测和中文API文档

@paddle-bot-old
Copy link

Sorry to inform you that a9ccee0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Sep 1, 2022
@luotao1
Copy link
Contributor

luotao1 commented Sep 7, 2022

@GuoQuanhao 感谢你在飞桨黑客松1期的贡献

有任何问题欢迎随时联系我们~

@paddle-bot
Copy link

paddle-bot bot commented Jan 11, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants