fix BatchNorm for fp16 #36376
Merged
fix BatchNorm for fp16 #36376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ceci3
reviewed
Oct 13, 2021
| @@ -563,7 +563,10 @@ def __init__(self, | |||
| self._bias_attr = bias_attr | |||
| self._use_global_stats = use_global_stats | |||
|
|
|||
| self._dtype = 'float32' | |||
| if get_default_dtype() == 'float16': | |||
There was a problem hiding this comment.
这样的话default type是fp16的话，不是还是强制改成了fp32嘛？
There was a problem hiding this comment.
是必须强制改成fp32，因为精度问题，batchnorm 是明确要求参数不能是fp16的，一般fp16输入都是用fp32的来表达参数，输入可以是fp16，区别在于 set_default_dtype，这个会改变全局的 dtype，而这个位置应该只是改变当前层的 dtype，所以应该只改变局部dtype，而不是全局 dtype
ceci3
approved these changes
Oct 13, 2021
GuoxiaWang
added a commit
to GuoxiaWang/Paddle
that referenced
this pull request
Oct 25, 2021
* fix BatchNorm for fp16
fuyinno4
pushed a commit
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
fix BatchNorm for fp16