[PaddlePaddle Hackathon] add paddle.zeropad2d #36383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! |
zhiboniu
reviewed
Oct 20, 2021
|
|
||
| def test_support_pad1(self): | ||
| """ | ||
| test the type of 'pad' is int. |
python/paddle/tensor/creation.py
Outdated
| Args: | ||
| x(Tensor): The input tensor with data type float32/float64/int32/int64. | ||
| pad(Tensor | List[int] | Tuple[int]): The padding size with data type int. | ||
| The input dimension should be 3 and pad has the form (pad_left, pad_right, |
There was a problem hiding this comment.
dimension should be 3 与 后面不一致
python/paddle/tensor/creation.py
Outdated
| .. code-block:: text | ||
| x = [[[[1., 2., 3.], | ||
| [4., 5., 6.]]]] | ||
| pad = [0, 0, 0, 0, 0, 0, 1, 1,] |
|
|
||
| x_dim = len(x.shape) | ||
|
|
||
| assert x_dim == 4, "input tensor dimension should be 4, but got {}".format( |
| @@ -79,6 +79,7 @@ | |||
| from .tensor.creation import ones_like # noqa: F401 | |||
| from .tensor.creation import zeros # noqa: F401 | |||
| from .tensor.creation import zeros_like # noqa: F401 | |||
| from .tensor.creation import zeropad2d # noqa: F401 | |||
There was a problem hiding this comment.
需要添加到all列表中，另外需要实现paddle.nn.ZeroPad2d
python/paddle/tensor/creation.py
Outdated
| @@ -381,6 +381,75 @@ def zeros_like(x, dtype=None, name=None): | |||
| return full_like(x=x, fill_value=0, dtype=dtype, name=name) | |||
|
|
|||
|
|
|||
| def zeropad2d(x, pad, data_format="NCHW", name=None): | |||
| """ | |||
| Pad tensor with 0 according to 'pad'. | |||
There was a problem hiding this comment.
可以更详细一点，让别人看描述就知道用途甚至用法。
站在你自己看文档的角度，怎么描述可以让你更快速了解这个API是否是你需要的
|
Sorry to inform you that 1ba8ea6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
很多CI都挂了，需要解决一下哈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
添加paddle.zeropad2d以及对应的测试案例