Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPU] update inference cmake, test=develop #36505

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Oct 18, 2021

PR types

New features

PR changes

Others

Describe

Update inference_lib.cmake for NPU, and also add Ascend Toolkit and Driver version.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@qili93 qili93 requested review from zhiqiu and jiweibo October 19, 2021 02:48
file(APPEND ${version_file}
"Ascend Toolkit version: ${ASCEND_TOOLKIT_VERSION}\n"
"Ascend Driver version: ${ASCEND_DRIVER_VERSION}\n")
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不打开 WITH_ASCEND_CXX11, C++预测实际上没法用,可以考虑把这个也加到version.txt中

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added "WITH_ASCEND_CXX11: ${WITH_ASCEND_CXX11}\n"

jiweibo
jiweibo previously approved these changes Oct 19, 2021
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiweibo
jiweibo previously approved these changes Oct 19, 2021
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 49d7bd3 into PaddlePaddle:develop Oct 19, 2021
@qili93 qili93 deleted the ascend_infer_cmake branch October 19, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants