Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTen] Organize pten unitests and directory #36948

Merged
merged 4 commits into from
Nov 5, 2021
Merged

[PTen] Organize pten unitests and directory #36948

merged 4 commits into from
Nov 5, 2021

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Nov 2, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

[PTen] Organize pten unitests and directory

Pten单测目前比较混乱，放置位置缺乏统一规则，且部分单测高层和底层实现在同一个文件，不利于后续编译拆分，故本PR进行统一整理，并明确后续的基础规则：

  1. 按照pten目录下的一级子目录整理，目前有对应单测的目录包括：api，common，core，kernels，后续可根据需求新增
  2. 单测一级目录下，不再设置过多子目录，避免目录层级过于复杂，例如core下即使源代码有子目录，单测对应目录下也不再继续设置目录
  3. api目录下单测和kernels目录下单测要分开整理，因为后续的推理可能不会编译api目录的内容，仅编译kernels内容，单测管理上需要便于编译拆分

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen previously approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测整理，被检测为单测删除

MingMingShangTian
MingMingShangTian approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 9a53477 into PaddlePaddle:develop Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

@MingMingShangTian MingMingShangTian MingMingShangTian approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenwhql @zyfncg @MingMingShangTian @YuanRisheng @XieYunshen @raindrops2sea