Fix dropout static when axis != None #37223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… fix_dropout_axis
guoshengCS
reviewed
Nov 25, 2021
| @@ -940,6 +940,7 @@ def get_attrs(prog, dropout_prob, is_test, seed): | |||
|
|
|||
| #get mask shape | |||
| input_shape = x.shape | |||
| input_shape_tensor = paddle.shape(x) | |||
There was a problem hiding this comment.
是说动态图的时候可以少走一个op是么
guoshengCS
reviewed
Nov 25, 2021
| x=input, p=0.7, axis=1, training=True, mode='upscale_in_train') | ||
|
|
||
| in_np = np.ones([40, 40]).astype("float32") | ||
| in_np2 = np.ones([1, 250000000]).astype("float32") |
There was a problem hiding this comment.
因为这个指定axis的分支不会走dropout op，感觉加的单测不用和去dropout OP比较，能跑下来就行，这个大size的单测可能会带来其他问题
guoshengCS
approved these changes
Nov 26, 2021
smallv0221
added a commit
to smallv0221/Paddle
that referenced
this pull request
Nov 26, 2021
* fix dropout static when axis != None * update dropout test * add dropout test * fix test * Update test_dropout_op.py * Update test_dropout_op.py * fix testcase * fix testcase * Update test_dropout_op.py * fix testcase * fix testcase * optimize perf * add new test * fix testcase
XiaoguangHu01
pushed a commit
that referenced
this pull request
Nov 29, 2021
* fix dropout static when axis != None * update dropout test * add dropout test * fix test * Update test_dropout_op.py * Update test_dropout_op.py * fix testcase * fix testcase * Update test_dropout_op.py * fix testcase * fix testcase * optimize perf * add new test * fix testcase
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* fix dropout static when axis != None * update dropout test * add dropout test * fix test * Update test_dropout_op.py * Update test_dropout_op.py * fix testcase * fix testcase * Update test_dropout_op.py * fix testcase * fix testcase * optimize perf * add new test * fix testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
Fix dropout static when axis != None