[PTen] Add compatible reshape method for Tensor #37281
Merged
+41
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… pten/add_reshape_method_for_custom_op
Shixiaowei02
previously approved these changes
Nov 18, 2021
paddle/pten/api/lib/tensor.cc
Outdated
| "instead. " | ||
| "reason: `reshape` means changing the tensor shape without " | ||
| "touching underlying data, this requires the total size of " | ||
| "the tensor to remains constant."; |
There was a problem hiding this comment.
to remains => to remain
… pten/add_reshape_method_for_custom_op
YuanRisheng
previously approved these changes
Nov 18, 2021
zyfncg
previously approved these changes
Nov 18, 2021
paddle/pten/api/lib/tensor.cc
Outdated
| framework::make_ddim(shape)); | ||
| } else { | ||
| PADDLE_THROW(platform::errors::Unimplemented( | ||
| "Only supported reshape operation on DenseTensor now.")); |
chenwhql
dismissed stale reviews from zyfncg, YuanRisheng, and Shixiaowei02
via
fd092f3
… pten/add_reshape_method_for_custom_op
Shixiaowei02
approved these changes
Nov 19, 2021
zyfncg
approved these changes
Nov 19, 2021
YuanRisheng
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
[PTen] Add compatible reshape method for Tensor
#37122 的TODO事项之一，恢复Tensor的reshape接口支持，确保兼容，目前reshape本质上仍是底层Tensor的Resize功能，由于这里reshape接口的含义和Python端reshape接口含义有出入，所以这里的reshape将会deprecated