Optimize cinn_cache_key by replace GraphToProgram to Dot string #37317
+56
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… optimize_cache_key
zhhsplendid
reviewed
Nov 18, 2021
| std::string CinnCacheKey::HashGraph(const ir::Graph& graph) { | ||
| // using Dot to unqiue graph | ||
| inference::analysis::Dot dot; | ||
| std::unordered_map<const ir::Node*, std::string> node2dot; |
There was a problem hiding this comment.
Just a question, can we reuse id of ir::Node instead of creating your own id?
In that case we can save the std::unordered_map data structure and corresponding insert/find operations
There was a problem hiding this comment.
node.h states that DO NOT USE node id. To be discussed in the future.
| @@ -39,13 +44,42 @@ CinnCacheKey::CinnCacheKey(const ir::Graph& graph, | |||
| this->SetKey(graph, input_shapes, arch_str); | |||
| } | |||
|
|
|||
| std::string CinnCacheKey::HashGraph(const ir::Graph& graph) { | |||
There was a problem hiding this comment.
Hash usually return hash type. Can we call it GraphHashString or GraphHashStr?
Or you just return hash type at line 73 while let caller of this function make it to string.
There was a problem hiding this comment.
Done.Changed to return size_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
优化
cinn_cache_key的生成方式，通过替换非常耗时的GraphToProgram为简约的Dot字符串