Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dygraph to eager -- TensorWrapper, EagerUtils, GlobalUtils #37466

Merged
merged 21 commits into from
Nov 24, 2021

Conversation

JiabinYang
Copy link
Contributor

PR types

New features

PR changes

Others

Describe

This is trying to add TensorWrapper: Wrap forward tensor for backward.
EagerUtils: Utilities used by framework
GlobalUtils: Global Utilities live as long as program

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhiqiu
zhiqiu previously approved these changes Nov 23, 2021
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for const_cast

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不重要,这几个文件好像都多了一行空的注释,建议后续移除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的 感谢

@JiabinYang JiabinYang merged commit 1799c03 into PaddlePaddle:develop Nov 24, 2021
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
…addlePaddle#37466)

* Add EagerTensor and tests

* remove useless enforce

* remove comment in cmake

* support autograd meta

* support grad node info test

* support grad_node_info

* add more edge test

* remove Python.h

* add tensor wrapper with tests

* support compute require grad and stop gradient

* support sync methods and global utils

* support pure cpu test

* refine error msg

* refine error msg

* refine error info

* fix npu error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants