-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dygraph to eager -- TensorWrapper, EagerUtils, GlobalUtils #37466
Refactor dygraph to eager -- TensorWrapper, EagerUtils, GlobalUtils #37466
Conversation
… refactor_dygraph_to_eager
… refactor_dygraph_to_eager2
… refactor_dygraph_to_eager2
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for const_cast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不重要,这几个文件好像都多了一行空的注释,建议后续移除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的 感谢
…addlePaddle#37466) * Add EagerTensor and tests * remove useless enforce * remove comment in cmake * support autograd meta * support grad node info test * support grad_node_info * add more edge test * remove Python.h * add tensor wrapper with tests * support compute require grad and stop gradient * support sync methods and global utils * support pure cpu test * refine error msg * refine error msg * refine error info * fix npu error
PR types
New features
PR changes
Others
Describe
This is trying to add
TensorWrapper
: Wrap forward tensor for backward.EagerUtils
: Utilities used by frameworkGlobalUtils
: Global Utilities live as long as program