[fleet_executor] Complete compute interceptor #37485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
FeixLiu
approved these changes
Nov 24, 2021
| void Compute(const InterceptorMessage& msg); | ||
|
|
||
| private: | ||
| std::unordered_set<int64_t> upstream_deps_; | ||
| // FIXME(wangxi): if use step_ and max_steps_, how to restart step_ from 0 |
There was a problem hiding this comment.
There is a message RESET, which was designed to reset the step_ to 0.
There was a problem hiding this comment.
那感觉还得加一个start的interceptor，发送开始信息，然后到了指定micro_step后，再发reset信息。
|
现在这么设计是不是停不下来呀，需要等那个step_的开发？outbuffer和inready都可以根据 |
是的，停不下来，reset不能把interceptor的线程停下来，只有stop可以。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Compute interceptor 完成上下游消息依赖与消息发送。