Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fleet_executor] Hold the carrier while running for one micro step. #37605

Merged
merged 4 commits into from
Nov 29, 2021
Merged

[fleet_executor] Hold the carrier while running for one micro step. #37605

merged 4 commits into from
Nov 29, 2021

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Nov 26, 2021

PR types

Others

PR changes

Others

Describe

  1. Hold the carrier while running for one micro step.
  2. Move the stop message handle to each handlers.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu requested a review from wangxicoding November 26, 2021 10:02
wangxicoding
wangxicoding approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/distributed/fleet_executor/compute_interceptor.cc

TryStop();
if (out_buffs_.size() == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有好几个汇节点怎么办

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个逻辑估计后面还要改

@FeixLiu FeixLiu merged commit 74ca89e into PaddlePaddle:develop Nov 29, 2021
@FeixLiu FeixLiu deleted the hold_carrier branch November 29, 2021 05:46
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
@FeixLiu @Zjq9409
[fleet_executor] Hold the carrier while running for one micro step. (P…
e3ebca6 
…addlePaddle#37605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxicoding wangxicoding wangxicoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FeixLiu @wangxicoding