Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle-Inference] fix_ele_convert: IElementWiseLayer can broadcast #37908

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

Wangzheee
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

修复elementwise在维度相同时可以广播的问题

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 7, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -228,7 +228,7 @@ class ElementwiseTensorOpConverter : public OpConverter {
}
};

if (CheckDims(dims_x, dims_y)) {
if (dims_x.nbDims == dims_y.nbDims) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check一下单测吧

Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit f695dc9 into PaddlePaddle:develop Dec 9, 2021
Wangzheee added a commit to Wangzheee/Paddle that referenced this pull request Dec 10, 2021
…addlePaddle#37908)

* fix_ele_convert: IElementWiseLayer can broadcast

* fix_ele_convert
Superjomn pushed a commit that referenced this pull request Dec 13, 2021
…37908) (#38032)

* fix_ele_convert: IElementWiseLayer can broadcast

* fix_ele_convert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants