[PSLIB] Add Metrics Module, Support User-defined Add Metric #38230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 1.8_add_metrics_module
danleifeng
reviewed
Dec 23, 2021
| double _bucket_error = 0; | ||
| std::unordered_set<uint64_t> _uid_keys; | ||
|
|
||
| // std::vector<std::shared_ptr<memory::Allocation>> _d_positive; |
There was a problem hiding this comment.
could remove these lines.
| // std::vector<std::shared_ptr<memory::Allocation>> _d_negative; | ||
| // std::vector<std::shared_ptr<memory::Allocation>> _d_abserr; | ||
| // std::vector<std::shared_ptr<memory::Allocation>> _d_sqrerr; | ||
| // std::vector<std::shared_ptr<memory::Allocation>> _d_pred; |
There was a problem hiding this comment.
could remove these lines.
| int _table_size; | ||
| std::vector<double> _table[2]; | ||
| // std::unordered_map<uint64_t, | ||
| // std::map<uint32_t, std::pair<uint64_t, uint64_t>>> |
There was a problem hiding this comment.
could remove these lines.
| // double total_time = 0.0; | ||
| // double compute_time = 0.0; | ||
| // double allreduce_time = 0.0; | ||
| // double reset_time = 0.0; |
There was a problem hiding this comment.
could remove useless lines
There was a problem hiding this comment.
you'd better check all the files with useless code.
…into 1.8_add_metrics_module
…ddle#38789) * [PSLIB] Add Metrics Module, Support User-defined Add Metric * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI Coverage * [PSLIB] Modify According to CI Coverage * modify role_maker * update CMakeLists.txt
fuyinno4
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe