[New API] add new api paddle.mode and paddle.Tensor.mode #38446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zoooo0820
changed the title
jeff41404
reviewed
Dec 28, 2021
| } | ||
|
|
||
| template <typename DeviceContext, typename T> | ||
| class ModeCPUKernel : public framework::OpKernel<T> { |
There was a problem hiding this comment.
shall we define ModeCPUKernel and ModeOpCUDAKernel in one class template?
There was a problem hiding this comment.
This will be fixed later
jeff41404
reviewed
Dec 28, 2021
paddle/fluid/operators/mode_op.h
Outdated
| framework::DDim trans_out_dims(in_dims); | ||
|
|
||
| for (size_t i = 0; i < trans.size(); i++) { | ||
| trans_dims[i] = in_dims[trans[i]]; |
There was a problem hiding this comment.
the variable name of trans/trans_dims is ambiguous, trans_axis or trans_shape may be clear ?
dingjiaweiww
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
add new api paddle.mode and paddle.Tensor.mode