Fix reduce bug 2.2 #38478
Merged
Fix reduce bug 2.2 #38478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
fix bug：
paddle.max / paddle.min api，在CPU设备上，当参数axis.size() == input.dims.size()，且存在axis[i] < 0时，结果出错。出错原因为判断reduce_all的逻辑不完善，没有考虑过negative的axis。
TIPS：对应预develop的修改PR #38476。由于develop上reduce_max的kernel迁移到了pten的实现，所以代码修改位置并不一致，无法直接cherry-pick。