[Unify Tensors PR #7] Merged LoDTensor with Tensor, test=allcases #38880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jim19930609
changed the title
jim19930609
force-pushed
the
merge_using_lod_tensor_as_tensor
branch
from
064eb19 to
d4f0596
Compare
jim19930609
requested review from
TCChenlong and
chenwhql
and removed request for
TCChenlong
chenwhql
reviewed
Jan 13, 2022
JiabinYang
reviewed
Jan 13, 2022
| @@ -31,7 +31,7 @@ void SetLoD(DstLoD* dst, const SrcLoD& src) { | |||
| } | |||
| } | |||
|
|
|||
| std::unique_ptr<pten::DenseTensor> MakePtenDenseTensor( | |||
| std::unique_ptr<pten::DenseTensor> MakePtenDenseTensorOrig( | |||
There was a problem hiding this comment.
Renamed to MakePtenDenseTensorBase().
Basically, these functions under "/pten/api/" will be removed after Tensor Unification. So I simply renamed some of the conflicting functions to avoid modifying their contents (which is throw-away work)
There was a problem hiding this comment.
k，then give some comment on them to show they are throw-away work.
There was a problem hiding this comment.
or not, since this PR is urgent...
TCChenlong
approved these changes
Jan 13, 2022
lanxianghit
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Previous works on constructing new tensor library "pten" introduced another Tensor type namely "DenseTensor", which temporarily co-exists with framework::Tensor and LoDTensor. In this series of PRs, we attempt to replace legacy "framework::Tensor and LoDTensor" by the newly implemented "DenseTensor", so as to facilitate the progress of "pten" joining original framework.
Merged C++ level LoDTensor into Tensor, so that all previous accesses to LoDTensor will be re-routed to Tensor. Same merge also happens at pybind level, where we merged all pybind methods of core.LoDTensor to core.Tensor. After that, we further patched core.LoDTensor method to core.Tensor so as to guarantee API compatibility.