Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for conv2D training error #38938

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Fix for conv2D training error #38938

merged 1 commit into from
Jan 17, 2022

Conversation

jakpiase
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Fix for conv2D training error on LeNet model. The issue was associated with wrong weights datatype(in inference they are in FP32 datatype, but in training they are in BF16). Also fixed error with no re-creating backward weights primitive descriptor in isCached method

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase requested a review from jczaja January 13, 2022 16:03
jczaja
jczaja approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested review from wozna and arlesniak January 13, 2022 16:36
@jczaja
Copy link
Contributor

jczaja commented Jan 13, 2022

@tsocha , @pawelpiotrowicz Please review

arlesniak
arlesniak approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase
Copy link
Contributor Author

Hi @Aganlengzi, could you please review and merge this PR?

Aganlengzi
Aganlengzi approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit 944ea43 into PaddlePaddle:develop Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsocha tsocha tsocha approved these changes

@arlesniak arlesniak arlesniak approved these changes

@jczaja jczaja jczaja approved these changes

@Aganlengzi Aganlengzi Aganlengzi approved these changes

@wozna wozna Awaiting requested review from wozna

Assignees

@Aganlengzi Aganlengzi

Labels
BF16 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakpiase @jczaja @Aganlengzi @arlesniak @tsocha