Host tracer and ProfilerController #39230
Merged
+635
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e206173.
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
rainyfly
reviewed
Jan 27, 2022
|
|
||
| RecordEvent(const std::string& name, const EventRole role, | ||
| const std::string& attr); | ||
| const std::string& attr, uint32_t level = 1); |
There was a problem hiding this comment.
Todo: 之后我们需要增加EventTracerType类型的参数，用来标记事件类型
There was a problem hiding this comment.
对的，后面要统一升级一次recordEvent接口
wanghuancoder
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe