Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when use extern_openblas and generator is ninja #39428

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

betterpig
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

fix bug when use extern_openblas and generator is ninja, the same bug see here
Pasted Graphic 2

@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 9, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在非Windows下也加上这个吧

@betterpig
Copy link
Contributor Author

在非Windows下也加上这个吧

done

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit f73f5b0 into PaddlePaddle:develop Feb 15, 2022
@betterpig betterpig deleted the ninja_in_openblas_ci branch February 18, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants