-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eager] Support SellectedRows MergeAdd case #39449
[Eager] Support SellectedRows MergeAdd case #39449
Conversation
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… move_trace_op_to_pten
… fix_trace_conflict
Thanks for your contribution! |
… support_sellected_rows_merge_case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
邮件已收到!!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
"calling this method.")); | ||
auto* src_tensor = static_cast<TType*>(src.impl().get()); | ||
return *src_tensor; | ||
} | ||
|
||
template <typename TType> | ||
TType* GetInnerMutable(paddle::experimental::Tensor* dst) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetEmptyInnerTensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Function optimization
PR changes
Others
Describe