Add ProcessGroupNCCL for distributed training #39737
Merged
+1,253
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForFishes
force-pushed
the
process_group_nccl
branch
from
e92b6f1 to
ff84be7
Compare
sandyhouse
reviewed
Feb 21, 2022
| @@ -1,5 +1,6 @@ | |||
| if(NOT WITH_PSCORE) | |||
| add_subdirectory(fleet_executor) | |||
| add_subdirectory(collective) | |||
| namespace paddle { | ||
| namespace distributed { | ||
|
|
||
| ProcessGroup::Task::Task(int rank, const std::vector<Tensor>& inputTensors, |
There was a problem hiding this comment.
用于后面的debug调试，打印rank信息，我记一下todo吧
| if (FLAGS_nccl_blocking_wait) { | ||
| // NOTE(shenliang03): It will block host for sync | ||
| while (!IsCompleted()) { | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(10)); |
There was a problem hiding this comment.
Make 10 a constexpr and easy to modify.
lanxianghit
previously approved these changes
Feb 22, 2022
ForFishes
dismissed stale reviews from lanxianghit and sandyhouse
via
b8176b3
XieYunshen
approved these changes
Feb 23, 2022
lanxianghit
approved these changes
Feb 23, 2022
raindrops2sea
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
增加ProcessGroup、ProcessGroupNCCL概念。屏蔽当前通信库中关于通信流和计算流概念。所有通信默认异步通信。
整体设计图：
TODO：