Add modified huber loss operator #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Sep 12, 2017
| }; | ||
|
|
||
| template <typename T> | ||
| struct ModifiedHuberLossForward { |
There was a problem hiding this comment.
为什么ModifiedHuberLossForward单独列出来，而backward却没有呢？
There was a problem hiding this comment.
前向是因为CPU和GPU共用，但是BP时两者分离，而且CPU逻辑比较简单，所以直接写循环了，GPU实现用的thrust，所以单列了
| } else if (inter_val_ptr[i] < 1) { | ||
| x_grad_ptr[i] = -2 * (1 - inter_val_ptr[i]) * (2 * y_ptr[i] - 1) * | ||
| out_grad_ptr[i]; | ||
| } else { |
There was a problem hiding this comment.
这个反向写的不对吧。92行和95行，都不需要再乘一个out_grad_ptr[i]
There was a problem hiding this comment.
@luotao1 在operator里，loss的写法和Paddle Layer的写法不一样，output_grad即使是1.0也是框架自动设置，或loss op外面自动设置的，所以需要乘out_grad_ptr[i]
xinghai-sun
reviewed
Sep 13, 2017
|
|
||
| PADDLE_ENFORCE_EQ(x->dims(), y->dims(), | ||
| "Dimensions of X and Y must be the same."); | ||
| PADDLE_ENFORCE_EQ(framework::arity(x->dims()), 2, |
There was a problem hiding this comment.
framework::arity(x->dims()) --> x->dims().size()
| "Dimensions of X and Y must be the same."); | ||
| PADDLE_ENFORCE_EQ(framework::arity(x->dims()), 2, | ||
| "Tensor rank of X must be 2."); | ||
| PADDLE_ENFORCE_EQ(x->dims()[1], 1, "Second dimension of X must be 1."); |
There was a problem hiding this comment.
--> The second
or The 2nd for short.
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput("X", "Input value of ModifiedHuberLossOp."); | ||
| AddInput("Y", "Target labels of ModifiedHuberLossOp."); | ||
| AddOutput("intermediate_val", |
There was a problem hiding this comment.
Should we have the same naming style? e.g. IntermediateVal ?
|
|
||
| def modified_huber_loss_forward(val): | ||
| if val < -1: | ||
| return -4 * a |
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into fix-3923-c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3923