[Phi] Migrate logical_and/or/not/xor into Phi #39942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
requested review from
YuanRisheng,
chenwhql,
MingMingShangTian and
zyfncg
YuanRisheng
previously approved these changes
Feb 25, 2022
|
|
||
| } // namespace phi | ||
|
|
||
| #define REGISTER_LOGICAL_CUDA_KERNEL(logical_and, func_type) \ |
There was a problem hiding this comment.
这里的宏定义参数命名 logical_and 需要改为 kernel_name?
There was a problem hiding this comment.
这里是因为我们CMake里有一个kernel的匹配逻辑，会去匹配第一个有效kernel_name，所以这里是故意这么写的
|
|
||
| } // namespace phi | ||
|
|
||
| #define REGISTER_LOGICAL_CPU_KERNEL(logical_and, func_type) \ |
There was a problem hiding this comment.
这里的宏定义参数命名 logical_and 需要改为 kernel_name?
YuanRisheng
approved these changes
Mar 1, 2022
| @@ -55,7 +55,7 @@ def setUp(self): | |||
|
|
|||
| def test_dygraph(self): | |||
| for place in self.places: | |||
| paddle.disable_static(place) | |||
| paddle.disable_static() | |||
There was a problem hiding this comment.
paddle.disable_static(place) 根据不同的place多次调用时，在除了第一次以外的调用，并不会根据place来切换tracer执行的place。这里 place的取值为cpu, gpu，导致第二次for循环本来应该用gpu的，但却使用了CPU。
zyfncg
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[Phi] Migrate logical_and/or/not/xor into Phi