Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eager] Pylayer #39989

Merged
merged 76 commits into from
Mar 30, 2022
Merged

[Eager] Pylayer #39989

merged 76 commits into from
Mar 30, 2022

Conversation

wanghuancoder
Copy link
Contributor

@wanghuancoder wanghuancoder commented Feb 28, 2022

PR types

New features

PR changes

Others

Describe

PyLayer对其老动态图版本,待开发功能

注:

  1. 在inplace逻辑上,赞未与老动态图对其
  2. double grad 暂未测试,待Eager支持paddle.grad后才能测试

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@@ -213,6 +213,49 @@ void GradNodeBase::SetGradInMeta(
}
}

void GradNodeBase::SetGradInMeta(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename it to avoid miss using of it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我给删了,相应的逻辑我在PyLayer的代码中实现了。

@@ -300,6 +343,41 @@ void GradNodeBase::SetGradOutMeta(
}
}

void GradNodeBase::SetGradOutMeta(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我给删了,相应的逻辑我在PyLayer的代码中实现了。

JiabinYang
JiabinYang previously approved these changes Mar 28, 2022
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenwhql
chenwhql previously approved these changes Mar 28, 2022
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

@wanghuancoder wanghuancoder dismissed stale reviews from chenwhql and JiabinYang via 4444d85 March 28, 2022 09:19
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 157c1a2 into PaddlePaddle:develop Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants