-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eager] Pylayer #39989
[Eager] Pylayer #39989
Conversation
Thanks for your contribution! |
… support_fill_zero
… support_fill_zero
… support_fill_zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
paddle/fluid/eager/grad_node_info.cc
Outdated
@@ -213,6 +213,49 @@ void GradNodeBase::SetGradInMeta( | |||
} | |||
} | |||
|
|||
void GradNodeBase::SetGradInMeta( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe rename it to avoid miss using of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我给删了,相应的逻辑我在PyLayer的代码中实现了。
paddle/fluid/eager/grad_node_info.cc
Outdated
@@ -300,6 +343,41 @@ void GradNodeBase::SetGradOutMeta( | |||
} | |||
} | |||
|
|||
void GradNodeBase::SetGradOutMeta( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我给删了,相应的逻辑我在PyLayer的代码中实现了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for PADDLE_ENFORCE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
Others
Describe
PyLayer对其老动态图版本,待开发功能
注: