[Eager][YAML] Supported array-type parsing for output tensors #40058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Mar 2, 2022
| @@ -213,8 +213,12 @@ def ParseYamlReturns(string): | |||
|
|
|||
| returns = [x.strip() for x in string.strip().split(",")] | |||
| for i in range(len(returns)): | |||
| ret = returns[i] | |||
| returns_list.append(["", ret, i]) | |||
| ret_type = returns[i] | |||
There was a problem hiding this comment.
If ret_type is a string like Tensor(out)，can it be found in yaml_types_mapping.keys()?
There was a problem hiding this comment.
okay this is interesting. So this function "ParseYamlReturns" is designed for parsing "forward_api" only, and it assumes there's no "name" associated with the outputs, in other words "Tensor[], Tensor" format outputs.
"backward_api", on the other hand, will use "ParseYamlReturnsWithName" instead, which assumes "Tensor(out), Tensor" format outputs.
zyfncg
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Before this patch, AutoCodeGen wasn't able to recognize array-typed output tensors in Yaml, for example "... -> Tensor". This feature will be enabled after this patch.