Refine MKLDNNMatrix and MKLDNNLayer #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Sep 11, 2017
| } | ||
| real* iData = getInputValue(0, CPU_DEVICE)->getData(); | ||
| inVal_->setData(iData); | ||
| } |
There was a problem hiding this comment.
updateInputData这个函数，不同的mkldnn layer的处理方式会不一样么？
There was a problem hiding this comment.
处理方式是一样的，但是可能别的layer不是用inVal_了
There was a problem hiding this comment.
如果处理方式是一样的，那updateInputData的实现应该放在MKLDNNLayer中：
void MKLDNNLayer::updateInputData(MKLDNNMatrix* val) {
if (inputLayers_[0]->getType() != "data") {
return;
}
real* iData = getInputValue(0, CPU_DEVICE)->getData();
val->setData(iData);
}
这里，updateInputData(inVal_)即可。
There was a problem hiding this comment.
嗯，是的。不过我准备下一个PR，把这个函数放到父类，所以下一个一起改掉吧
|
Some addition refer to #4011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR of #3974