[Phi] Migrate tile_op into Phi #40371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
requested review from
chenwhql,
YuanRisheng,
MingMingShangTian and
zyfncg
| namespace paddle { | ||
| namespace operators { | ||
|
|
||
| inline std::vector<int> get_repeat_times( |
There was a problem hiding this comment.
get_repeat_times 要不要改为驼峰命名？
There was a problem hiding this comment.
这个函数只在fluid 下的XPU/NPU使用，因此两个设备的Kernel未在此PR迁移，因此此处仅做拆分。
| out->set_dims(phi::make_ddim(out_shape)); | ||
| if (out_shape[0] == x_dims[0]) { | ||
| out->share_lod(x); | ||
| } |
There was a problem hiding this comment.
我在adam的PR里改，这个PR是否可以先合入。
YuanRisheng
reviewed
Mar 11, 2022
| if (just_copy) { | ||
| dev_ctx.template Alloc<T>(x_grad); | ||
|
|
||
| paddle::framework::TensorCopy( |
| @@ -0,0 +1,67 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这个文件里的内容或许可以迁到funcs下，将传入的context变成，多个参数传入
There was a problem hiding this comment.
这个函数只在fluid 下的XPU/NPU使用，因此两个设备的Kernel未在此PR迁移，因此此处仅做拆分。
MingMingShangTian
approved these changes
Mar 11, 2022
zyfncg
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
[Phi] Migrate tile_op into Phi.