-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hackathon No.26] #40487
[Hackathon No.26] #40487
Conversation
✅ This PR's description meets the template requirements! |
Thanks for your contribution! |
你的 PR 提交成功,感谢你对于开源项目的贡献 |
PR 格式检查通过,你的PR 将接受Paddle 专家以及开源社区的review,请及时关注PR 动态 |
67b1252
to
4990c15
Compare
根据流程,方案设计通过之后才能开始代码review,请仔细查看对应方案设计文档PR的修改意见,修改之后对应进行代码部分修改,当文档合入之后方可进行代码 PR 的review。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要通过所有CI(除PR-CI-Static-Check)之后才能进行进一步review
请重新拉取develop的代码,解决冲突后重新提交该PR |
1bffa34
to
e2117ab
Compare
请先通过CI噢~ |
请问这个的CI可以不用通过吗 PR-CI-Kunlun-KP-Build |
可以的~ |
cla和CheckPRTemplate 是需要通过的噢~ |
…riplet_margin_loss
…riplet_margin_loss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'triplet_margin_loss' * 'test_file_corret' * '2022_03_27' * 2022_04_05 * 2022-04-17_1 * 2022-04-17 * 2022-04-17_2 * 2022-04-25 * 2022-05-02_V1 * 2022-05-06_V1 * 2022-05-07_V1 * Update loss.py * Update loss.py * Update loss.py * Update loss.py * Update loss.py * Update loss.py * Update loss.py * Update loss.py * Update loss.py * Update test_triplet_margin_loss.py * Update loss.py * 2022-06-01_pre-commit * 2022-06-05 * 2022-06-06 * 2022-06-06 * code_style_check * code_style_check * Update loss.py * 2022-06-07_V2 * Update loss.py * Update loss.py
PR types
New features
PR changes
APIs
Describe
解决了issues:#40307
添加了paddle.nn.TripletMarginLoss以及paddle.nn.functional.triplet_margin_loss的函数
设计文档:PaddlePaddle/community#31
中文文档PR链接:PaddlePaddle/docs#4301