Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackathon No.26] #40487

Merged
merged 53 commits into from
Jun 17, 2022
Merged

Conversation

yangguohao
Copy link
Contributor

@yangguohao yangguohao commented Mar 12, 2022

PR types

New features

PR changes

APIs

Describe

解决了issues:#40307
添加了paddle.nn.TripletMarginLoss以及paddle.nn.functional.triplet_margin_loss的函数
设计文档:PaddlePaddle/community#31
中文文档PR链接:PaddlePaddle/docs#4301

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 12, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@dingjiaweiww
Copy link
Contributor

你的 PR 提交成功,感谢你对于开源项目的贡献

@dingjiaweiww
Copy link
Contributor

PR 格式检查通过,你的PR 将接受Paddle 专家以及开源社区的review,请及时关注PR 动态

@shiyutang
Copy link
Contributor

根据流程,方案设计通过之后才能开始代码review,请仔细查看对应方案设计文档PR的修改意见,修改之后对应进行代码部分修改,当文档合入之后方可进行代码 PR 的review。

Copy link
Contributor

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要通过所有CI(除PR-CI-Static-Check)之后才能进行进一步review

@shiyutang
Copy link
Contributor

请重新拉取develop的代码,解决冲突后重新提交该PR

@dingjiaweiww
Copy link
Contributor

请先通过CI噢~

@shiyutang shiyutang self-assigned this Mar 31, 2022
@shiyutang
Copy link
Contributor

  1. 需要增加设计文档链接,如图所示:
    06b8a2904adf5ec3c229031619c25f57

  2. 需要替换 in_dygraph_mode 如下图所示:
    4ac43d3d67cdea50a08659a006f90a19

@yangguohao
Copy link
Contributor Author

请问这个的CI可以不用通过吗 PR-CI-Kunlun-KP-Build

@dingjiaweiww
Copy link
Contributor

请问这个的CI可以不用通过吗 PR-CI-Kunlun-KP-Build

可以的~

@dingjiaweiww
Copy link
Contributor

cla和CheckPRTemplate 是需要通过的噢~

@yangguohao yangguohao dismissed stale reviews from XiaoguangHu01 and shiyutang via f06ad62 June 1, 2022 14:54
Ligoml
Ligoml previously approved these changes Jun 2, 2022
Ligoml
Ligoml previously approved these changes Jun 10, 2022
XiaoguangHu01
XiaoguangHu01 previously approved these changes Jun 10, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangguohao yangguohao dismissed stale reviews from XiaoguangHu01 and Ligoml via 187fa6d June 13, 2022 03:25
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 9bbcca2 into PaddlePaddle:develop Jun 17, 2022
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
* 'triplet_margin_loss'

* 'test_file_corret'

* '2022_03_27'

* 2022_04_05

* 2022-04-17_1

* 2022-04-17

* 2022-04-17_2

* 2022-04-25

* 2022-05-02_V1

* 2022-05-06_V1

* 2022-05-07_V1

* Update loss.py

* Update loss.py

* Update loss.py

* Update loss.py

* Update loss.py

* Update loss.py

* Update loss.py

* Update loss.py

* Update loss.py

* Update test_triplet_margin_loss.py

* Update loss.py

* 2022-06-01_pre-commit

* 2022-06-05

* 2022-06-06

* 2022-06-06

* code_style_check

* code_style_check

* Update loss.py

* 2022-06-07_V2

* Update loss.py

* Update loss.py
@yangguohao yangguohao deleted the triplet_margin_loss branch September 18, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants