-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hachathon No.30】 #40545
【Hachathon No.30】 #40545
Conversation
✅ This PR's description meets the template requirements! |
Thanks for your contribution! |
你的 PR 提交成功,感谢你对于开源项目的贡献 |
PR 格式检查通过,你的PR 将接受Paddle 专家以及开源社区的review,请及时关注PR 动态 |
根据流程,方案设计通过之后才能开始代码review,请仔细查看对应方案设计文档PR的修改意见,修改之后对应进行代码部分修改,当文档合入之后方可进行代码 PR 的review。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要重新拉取develop的代码,通过所有CI(除PR-CI-Static-Check)之后才能进行进一步review
b4c12ec
to
d534091
Compare
请先通过CI噢~ |
1 similar comment
请先通过CI噢~ |
d534091
to
a15eae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for docs
python/paddle/nn/layer/loss.py
Outdated
# Tensor([0.19165580]) | ||
|
||
""" | ||
def __init__(self, distance_function=None, margin=1.0, swap=False, reduction: str = 'mean', name=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the order of parameters here must same with RFC, here suggest to modify RFC distance_function
before margin
, and class name TripletMarginDistanceLoss
in RFC should be consistance with TripletMarginWithDistanceLoss
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已重提PR修改RFC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,确认和RFC一致。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2a4ed81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
APIs
Describe
解决了issues:#40303
添加了paddle.nn.TripletMarginWithDistanceLoss以及paddle.nn.functional.triplet_margin_with_distance_loss的函数
设计文档:PaddlePaddle/community#34
中文文档PR链接:PaddlePaddle/docs#4644