[Eager] Slice #40587
Merged
[Eager] Slice #40587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
JiabinYang
reviewed
Mar 17, 2022
| const paddle::platform::Place& place, | ||
| paddle::framework::AttributeMap* default_attrs, | ||
| bool use_default_attr_map, | ||
| const std::map<std::string, std::string>& inplace_map) { | ||
| VLOG(6) << "Running On Eager TraceOp with use_default_attr_map: " | ||
| << use_default_attr_map; | ||
| TraceOp<egr::EagerVariable>(type, ins, outs, std::move(attrs), place, false, | ||
| inplace_map, default_attrs, use_default_attr_map); | ||
| TraceOpImpl<egr::EagerVariable>(type, ins, outs, attrs, place, false, |
There was a problem hiding this comment.
这个我当面给你讲过，TraceOp会修改attr，所以我需要在前向时，传入attr的引用，让TraceOp完成attr->check相关动作，再将新的attr返回给Eager前向，这样，Eager前向把正确的attr保存到反向使用。
paddle/fluid/pybind/eager_method.cc
Outdated
| @@ -211,6 +228,21 @@ static PyObject* tensor_method__is_initialized(TensorObject* self, | |||
| EAGER_CATCH_AND_THROW_RETURN_NULL | |||
| } | |||
|
|
|||
| static PyObject* tensor_method__dense_tensor_is_initialized(TensorObject* self, | |||
There was a problem hiding this comment.
print(tensor)时，需要看LoDTensor是否初始化。否则我们的打印和老动态图的打印格式无法对齐。
There was a problem hiding this comment.
但是 Tensor自己的_initialized已经可以完成这个功能了把
| @@ -602,6 +638,216 @@ static PyObject* tensor__getitem_index_not_tensor(TensorObject* self, | |||
| EAGER_CATCH_AND_THROW_RETURN_NULL | |||
| } | |||
|
|
|||
| static PyObject* tensor_method__setitem_eager_tensor(TensorObject* self, | |||
| PyObject* args, | |||
zhiqiu
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Eager 对齐老动态图 Slice