Support sharding #40637
Merged
Support sharding #40637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… support_sharding
… support_sharding
… support_sharding
Comment on lines
+843
to
+846
| setattr(core.eager.Tensor, "cpu", cpu) | ||
| setattr(core.eager.Tensor, "cuda", cuda) | ||
| setattr(core.eager.Tensor, "_slice", _slice) | ||
| setattr(core.eager.Tensor, "_numel", _numel) |
There was a problem hiding this comment.
这些在老动态图下不需要patch吗？为啥pybind.cc里会添加_slice和_numel的接口
There was a problem hiding this comment.
这个不需要的 这几个接口在老动态下是在imperative.cc实现的
| } | ||
| VLOG(6) << "Tensor copy gradient from: " << src.name(); | ||
| auto* p_grad = egr::EagerUtils::mutable_grad(self->tensor); | ||
| if (p_grad) { |
There was a problem hiding this comment.
如果为null就不需要拷贝了吗？不需要给用户提示吗？
There was a problem hiding this comment.
这个目前先对其了老动态图的功能，以及这个是个隐藏接口，只会给分布式使用
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
This PR support
cpu,cuda,_clear,_slice,_numel,_copy_gradient_fromfor sharding in eager mode