-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable cudnn_convt #4076
enable cudnn_convt #4076
Conversation
@@ -169,6 +169,7 @@ class LayerType(object): | |||
EXCONV_LAYER = 'exconv' | |||
EXCONVTRANS_LAYER = 'exconvt' | |||
CUDNNCONV_LAYER = 'cudnn_conv' | |||
CUDNNCONVTRANS_LAYER = 'cudnn_convt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个在v1 下是自动判断设置吗?这样修改是不是需要显示地手工指定呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看cudnn的conv和convt python代码是同一段,只是在设置上有区别
if layer_type:
if dilation > 1 or dilation_y > 1:
assert layer_type in ["cudnn_conv", "cudnn_convt"]
if trans:
assert layer_type in ["exconvt", "cudnn_convt"]
else:
assert layer_type in ["exconv", "cudnn_conv"]
lt = layer_type
else:
lt = LayerType.CONVTRANS_LAYER if trans else LayerType.CONV_LAYER
c++代码是同一段,只是在配置上有区别
ProjectionConfig *conf = new ProjectionConfig();
if (isDeconv_) {
conf->set_type("convt");
} else {
conf->set_type("conv");
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
曾经有过这个issue #2984 ,和相关的PR,为什么依然不能自动设置呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 是这一个 #3049
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该之前也遇到,如果确认解决,也关闭相关的issue吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #4074
fix #2984