fix build_cinn_pass internal var may be control var problem #40812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CtfGo
reviewed
Mar 23, 2022
Comment on lines
308
to
309
| // skip control var | ||
| continue; |
There was a problem hiding this comment.
添加TODO说明可能存在问题以及待改进；添加VLOG，便于debug
… fix_cinn_internal_var_empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
In
BuildCinnPass, an internal var may be a control var, that means its vardesc is empty. In previous code, we reported the error and existed when we check the vardesc failed, now we choice skip the vars because of cinn not support control var.