Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] refactored eager_gen.py PR #1 #40815

Merged
merged 9 commits into from
Mar 24, 2022

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Mar 22, 2022

PR types

Function optimization

PR changes

Others

Describe

Refactored automatic code generation for final state eager dygraph functions. In additional to code polish, three major changes are further involved:

  1. Added codegen_utils.py which includes common helper functions, and base class of YamlGenerator and FunctionGenerator.
  2. Grouped up logics for Dygraph Function Generation & GradNode Generation and uses a class named "DygraphSingleFunctionGenerator" to manage all the corresponding functions.
  3. Code generation across different APIs (normal api, sparse api, string api, etc) were managed by DygraphYamlGenerator

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim19930609 jim19930609 merged commit 68c9e3e into PaddlePaddle:develop Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants