-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] Move mul op kernel into phi #40833
Merged
chenwhql
merged 6 commits into
PaddlePaddle:develop
from
chenwhql:phi/move_mul_kernl_and_infershape
Mar 24, 2022
Merged
[Phi] Move mul op kernel into phi #40833
chenwhql
merged 6 commits into
PaddlePaddle:develop
from
chenwhql:phi/move_mul_kernl_and_infershape
Mar 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingMingShangTian
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zyfncg
approved these changes
Mar 24, 2022
XiaoguangHu01
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YuanRisheng
approved these changes
Mar 24, 2022
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Jun 15, 2022
This reverts commit 1b49181.
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Jun 16, 2022
This reverts commit 1b49181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
[Phi] Move mul op kernel into phi
mul op统计调用频次超过800,因此尽管其是1.x算子,但出于兼容考虑,将Mul Op迁移至phi,原先的Mul Op实质上是带有flatten性质的matmul运算,因此kernel更名为matmul_with_flatten,并和matmul kernel放到一起管理
这个kernel暂时不需要yaml声明,2.x动态图API已不再使用