Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a neon::relu activation function. #4150

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Add a neon::relu activation function. #4150

merged 2 commits into from
Sep 18, 2017

Conversation

hedaoyuan
Copy link
Contributor

No description provided.

@hedaoyuan hedaoyuan requested a review from Xreki September 18, 2017 06:02
Xreki
Xreki approved these changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried the build for arm64, and it works.
LGTM.

paddle/cuda/include/hl_tensor_ops.h
@@ -461,7 +461,7 @@ class add<float32x4_t> {
public:
INLINE float32x4_t operator()(const float32x4_t a,
const float32x4_t b) const {
return vmulq_f32(a, b);
return vaddq_f32(a, b);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug, :bowtie:

@hedaoyuan hedaoyuan merged commit d59295f into PaddlePaddle:develop Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedaoyuan @Xreki