-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #41872
【PaddlePaddle Hackathon 2】18、为 Paddle 新增 paddle.heaviside 和 paddle.Tensor.heaviside API #41872
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
关于该API的PR,前序讨论及修改记录请见 #40934
- 当前还有一个小地方的问题,修改完成即可
@@ -268,6 +268,7 @@ | |||
from .tensor.math import fmin # noqa: F401 | |||
from .tensor.math import inner # noqa: F401 | |||
from .tensor.math import outer # noqa: F401 | |||
from .tensor.math import heaviside # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里请也将heaviside
添加到这个文件的__all__
列表中,使得paddle.heviside
作为公开API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
完成
现在PR-CI-Coverage显示C++代码的行覆盖率为41/46=89.1%,不足90%。 我们可以看到 希望评审老师能解答一下或者再给点修改建议。 |
这个ci是elementwise_sig.cc的问题,已找单测相关同学处理完成 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请再处理一下Docs文档生成的ci问题,生成正确的文档链接后继续下面的review流程 |
PR格式检查通过,你的PR将接受Paddle专家以及开源社区的review,请及时关注PR动态。 |
已经生成正确的文档。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for api docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry to inform you that 12ebfdb's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
f271150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
APIs
Describe
解决了 issue:#40315
实现了 paddle.heaviside。paddle.heaviside(x, y) 在 x>0 时返回 1,在 x=0 时返回 y,在 x<0 时返回 0。
设计文档:PaddlePaddle/community#57
中文文档:PaddlePaddle/docs#4641