Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the race condition in cumsum operator #42205

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

leo0519
Copy link
Collaborator

@leo0519 leo0519 commented Apr 24, 2022

PR types

Bug fixes

PR changes

OPs

Describe

Followed by the issue #41932, the cumsum UT failed on P100.

The reason is that the BlockReverse function in cumsum_op has race condition.
This PR modifies part of codes to avoid hazard.

@leo0519 leo0519 added the NVIDIA label Apr 24, 2022
@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Apr 24, 2022
@leo0519 leo0519 force-pushed the cumsum-race-condition branch from d3840e2 to 4e01a0d Compare April 25, 2022 08:22
@wawltor wawltor self-requested a review April 27, 2022 03:10
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 5d72945 into PaddlePaddle:develop Apr 27, 2022
wawltor pushed a commit to wawltor/Paddle that referenced this pull request May 5, 2022
* Fix the race condition in cumsum operator

* Optimize cumsum operator
ZeyuChen pushed a commit that referenced this pull request May 6, 2022
* Fix the race condition in cumsum operator

* Optimize cumsum operator

Co-authored-by: Leo Chen <39020268+leo0519@users.noreply.github.com>
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants