Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eager] Optimize eager with merged edges and small_vector #42350

Merged
merged 2 commits into from
Apr 29, 2022
Merged

[Eager] Optimize eager with merged edges and small_vector #42350

merged 2 commits into from
Apr 29, 2022

Conversation

JiabinYang
Copy link
Contributor

@JiabinYang JiabinYang commented Apr 28, 2022 •
edited
Loading

PR types

Performance optimization

PR changes

Others

Describe

This PR using small_vector for most of slot container and then merge edges into grad_slot_meta to save some construction time.
Before:
infoflow 2022-04-29 17-43-36
after:
infoflow 2022-04-29 17-45-21

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@JiabinYang JiabinYang changed the title [Eager] Optimzier eager with merged edges and small_vector [Eager] Optimize eager with merged edges and small_vector Apr 28, 2022
wanghuancoder
wanghuancoder approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 2bee99d into PaddlePaddle:develop Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiabinYang @chenwhql @wanghuancoder @XiaoguangHu01