Skip to content

[cherry-pick]fix the v100 cuda11.2 matmul_v2 and elementwise_div test case #42479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

[cherry-pick]fix the v100 cuda11.2 matmul_v2 and elementwise_div test case #42479

merged 1 commit into from
May 5, 2022

Conversation

wawltor
Copy link
Contributor

@wawltor wawltor commented May 4, 2022 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

fix the v100 cuda11.2 matmul_v2 and elementwise_div test case， cherry pick from the PR: #42477

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 4, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators May 5, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation May 5, 2022
@wawltor wawltor closed this May 5, 2022
@wawltor wawltor reopened this May 5, 2022
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators May 5, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation May 5, 2022
@wawltor wawltor changed the title [cherry-pick]fix the v100 cuda11.2 matmul_v2 and elementwise_div bug [cherry-pick]fix the v100 cuda11.2 matmul_v2 and elementwise_div test case May 5, 2022
jzhang533
jzhang533 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cublas中的matmul需要sm80 later，基于此来跳过TestMatMulOpBf16Case是OK的。

但是，在NV的卡上，cuda11.0 later， sm53 later就会有bfloat16 dtype，基于sm80 later才会有bfloat16的判断条件（is_bfloat16_supported）需要讨论看怎么调整。

ZeyuChen
ZeyuChen approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen merged commit e052fde into PaddlePaddle:release/2.3 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@kolinwei kolinwei kolinwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wawltor @jzhang533 @ZeyuChen @kolinwei