Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tempfile to place the temporary files #42626

Merged
merged 4 commits into from
May 12, 2022

Conversation

zlsh80826
Copy link
Collaborator

@zlsh80826 zlsh80826 commented May 10, 2022

PR types

Bug fixes

PR changes

Others

Describe

  1. Both test_resnet and test_build_strategy use inference directory and resnet.dygraph.params as temporary files, it may cause file race if we running both unit test simultaneously. This PR use tempfile to store those temporary files.
  2. Warp helper functions in test_resnet.py for test_build_strategy.py to use.
  3. Use tempfile for test_bert and test_transformer
  4. Use tempfile for test_dataset and test_dataset_consistency_inspection.py, which may cause overwriten on test_run_with_dump_a.txt

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit eca8a57 into PaddlePaddle:develop May 12, 2022
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants