-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudnn error for BatchNorm1D kernel #43072
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 能否在comment区域补充下,之前测试case的性能以及与竞品的对比:
- 是否可以跑大bs;
- 大bs下的性能对比。
这个PR主要是先处理掉大batch下报错的问题,有关性能方面的进一步优化在 #43530 中进行了详细的描述 @JamesLim-sy |
Sorry to inform you that 3c26e1e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
PR types
Function optimization
PR changes
OPs
Describe
1 Motivation:
2 Design:
3 Evaluation: