Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cudnn error for BatchNorm1D kernel #43072

Merged
merged 16 commits into from
Jun 21, 2022
Merged

Conversation

EsdeathYZH
Copy link
Contributor

@EsdeathYZH EsdeathYZH commented May 29, 2022

PR types

Function optimization

PR changes

OPs

Describe

1 Motivation:

2 Design:

3 Evaluation:

  • TODO

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels May 29, 2022
@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented May 29, 2022

CLA assistant check
All committers have signed the CLA.

@EsdeathYZH EsdeathYZH changed the title refactor code structure Optimize BatchNorm1D kernel May 29, 2022
@EsdeathYZH EsdeathYZH changed the title Optimize BatchNorm1D kernel Fix cudnn error for BatchNorm1D kernel Jun 7, 2022
zkh2016
zkh2016 previously approved these changes Jun 8, 2022
ceci3
ceci3 previously approved these changes Jun 8, 2022
Copy link
Contributor

@ceci3 ceci3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EsdeathYZH EsdeathYZH dismissed stale reviews from ceci3 and zkh2016 via 26a43fc June 9, 2022 18:33
Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 能否在comment区域补充下,之前测试case的性能以及与竞品的对比:

  • 是否可以跑大bs;
  • 大bs下的性能对比。

@EsdeathYZH
Copy link
Contributor Author

LGTM. 能否在comment区域补充下,之前测试case的性能以及与竞品的对比:

  • 是否可以跑大bs;
  • 大bs下的性能对比。

这个PR主要是先处理掉大batch下报错的问题,有关性能方面的进一步优化在 #43530 中进行了详细的描述 @JamesLim-sy

@paddle-bot-old
Copy link

Sorry to inform you that 3c26e1e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zkh2016 zkh2016 merged commit bbe0fdb into PaddlePaddle:develop Jun 21, 2022
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants