Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the underflow of fp16 fake quantize operators #43088

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix the underflow of fp16 fake quantize operators #43088

merged 1 commit into from
May 31, 2022

Conversation

leo0519
Copy link
Collaborator

@leo0519 leo0519 commented May 30, 2022 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

The float16 fake quantize operators may lead to underflow when dividing the scale.

  1. Move the computation of fake quantize ops from float16 to float32 (dtype is still float16)
  2. Simplify the code of fake quantize op unit test

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels May 30, 2022
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@leo0519 leo0519 added the NVIDIA label May 30, 2022
qingqing01
qingqing01 approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingqing01 qingqing01 merged commit 0ae8a2d into PaddlePaddle:develop May 31, 2022
fuyou765 pushed a commit to fuyou765/Paddle that referenced this pull request Jun 7, 2022
@leo0519 @jeng1220 @fuyou765
Fix the underflow of fp16 fake quantize operators (PaddlePaddle#43088)
566a5c8 
Co-authored-by: Ryan Jeng <rjeng@nvidia.com>
yghstill added a commit to yghstill/Paddle that referenced this pull request Jun 20, 2022
@yghstill
cherry pick PaddlePaddle#43088 PaddlePaddle#40664
a413e33
@yghstill yghstill mentioned this pull request Jun 20, 2022
Merged
XiaoguangHu01 pushed a commit that referenced this pull request Jun 21, 2022
@yghstill
[cherry pick #43088 #40664] Add float16 to fake quantize/dequantize OP (
9783e88 
#43689)

* cherry pick #43088 #40664

* fix clang format
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@yghstill yghstill Awaiting requested review from yghstill

@wanghaoshuang wanghaoshuang Awaiting requested review from wanghaoshuang

@ceci3 ceci3 Awaiting requested review from ceci3

Assignees
No one assigned
Labels
NVIDIA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo0519 @qingqing01 @jeng1220