[geometric]Add paddle.geometric.send_ue_recv API #43174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that f961f9b's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
wawltor
reviewed
Aug 3, 2022
| src_index (Tensor): An 1-D tensor, and the available data type is int32, int64. | ||
| dst_index (Tensor): An 1-D tensor, and should have the same shape as `src_index`. | ||
| The available data type is int32, int64. | ||
| compute_type (str): Different compute types for x and e, including `add`, `sub`, `mul`, `div`. |
There was a problem hiding this comment.
compute_type、pool_type 的名字有参考其他开源repo相关API的名字吗？
There was a problem hiding this comment.
目前只有dgl 有相关 API，但起对应名字更加模糊，包括比如 op 对应 compute_type, reduce_op 对应 pool_type。感觉不具备参考意义。
|
|
||
| x_shape = paddle.shape(x) | ||
| y_shape = paddle.shape(y) | ||
| if len(x.shape) != len(y.shape): |
DesmonDay
commented
Aug 3, 2022
wawltor
reviewed
Aug 4, 2022
python/paddle/fluid/tests/unittests/test_graph_send_ue_recv_op.py
Outdated
Show resolved
Hide resolved
| AddOutput("Dst_count", | ||
| "Count tensor of Dst_index, mainly for MEAN pool_type.") | ||
| .AsIntermediate(); | ||
| AddAttr<std::string>("compute_type", |
wawltor
reviewed
Aug 4, 2022
wawltor
reviewed
Aug 5, 2022
wawltor
reviewed
Aug 5, 2022
wawltor
reviewed
Aug 5, 2022
| 0, | ||
| phi::errors::PreconditionNotMet( | ||
| "Required dim >= 0, but received dim = %d", dim)); | ||
| if (dim == 0) return 1; |
There was a problem hiding this comment.
Thread num 应该是warp的倍数，即32的倍数，这里取1不太合适，以及后续也有可能取到32以下的thread
wawltor
reviewed
Aug 5, 2022
| } | ||
|
|
||
| int64_t out_len = bcast_info.out_len; | ||
| const int ntx = FindNumThreads(out_len); // 一个block包含的Thread数 |
There was a problem hiding this comment.
这里的cuda的thread最大是1024，建议还是通过函数获取设备能支持的max thread num
wawltor
reviewed
Aug 5, 2022
wawltor
reviewed
Aug 5, 2022
|
|
||
| int64_t out_len = bcast_info.out_len; | ||
| const int ntx = FindNumThreads(out_len); | ||
| const int nty = CUDA_MAX_NUM_THREADS / ntx; |
There was a problem hiding this comment.
同上，CUDA_MAX_NUM_THREADS 变量控制
DesmonDay
changed the title
DesmonDay
force-pushed
the
add_send_e_recv
branch
from
a0bd902
to
a480092
Compare
…type to message_op
DesmonDay
force-pushed
the
add_send_e_recv
branch
from
a0d7acf
to
2b0bd9a
Compare
ZeyuChen
approved these changes
Aug 12, 2022
DesmonDay
added a commit
to DesmonDay/Paddle
that referenced
this pull request
Oct 13, 2022
* add init file * add op definition and infermeta * add kernel definition funcs * add broadcast infer shape * add gpu forward kernel * delete SUB and DIV * add x_grad * add template * add e_grad for min and max * fix small bug * temp commit * temp commit * add e_grad for sum and mean * fix some compile bug * fix compile bugs * fix compile problem * add sum forward unittest * fix broadcast error, add kernel sig, register e_grad, change unit test * fix grad * add temp grad fix * temp commit * add min max unittest * add max, min unittest, fix mul bug * add cpu forward sum and mean * add forward min max, fix mean unittest * add cpu backward min max * fix code-style * add backward sum mean * fix rocm ci * set uniitest timeout * fix bug of x broadcast to e, gpu grad * fix bug of x broadcast to e, cpu grad * rename BOOST_GET_CONST macro * fix rocm ci * mv graph_send_e_recv to graph_send_ue_recv * move out_size to IntArray * add eager op test * fix max pool type bug, add unittest for api * revise api doc * add fp16 for atomic min and max, add unittest * add unittest * add fp16 support for graph_send_recv * fix unittest fp16 bug * change OutSizeTensor to Out_size * move E to Y * add copyright, fix comment * review code * fix thread block size * fix thread block size * change api attribute name: pool_type to reduce_op, compute_type to message_op * change api attribute name, move pool_type to reduce_op, move compute_type to message_op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add paddle.geometric.send_ue_recv API, mainly used in graph learning domain.