Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matmul post-ops for fuses #43198

Merged
merged 5 commits into from
Jun 7, 2022
Merged

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Jun 4, 2022

PR types

Performance optimization

PR changes

OPs

Describe

  • create method for inserting oneDNN post-ops required for fuse passes (matmul+activation or matmul+elementwise),
  • reduce number of method arguments.

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Jun 4, 2022
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 4, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Silv3S
Copy link
Member Author

Silv3S commented Jun 4, 2022

@tsocha, @jczaja please review

Comment on lines +439 to +445
float activation_scale = (!force_fp32_output && has_activation)
? ctx.Attr<float>("Scale_out")
: 1.0f;

float scale_out_data = (force_fp32_output || has_activation)
? 1.0f
: ctx.Attr<float>("Scale_out");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested a review from jiangjiajun June 7, 2022 10:31
@jczaja
Copy link
Contributor

jczaja commented Jun 7, 2022

@jiangjiajun Please start your review

@jczaja jczaja merged commit 5434d66 into PaddlePaddle:develop Jun 7, 2022
@Silv3S Silv3S deleted the matmul_post_ops branch June 7, 2022 15:49
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 7, 2022

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants