Sync computation when Python invoke run
#4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
force-pushed
the
feature/add_wait_to_device_ctx
branch
from
ae95f2d
to
ba1f5b5
Compare
reyoung
commented
Sep 22, 2017
| }; | ||
|
|
||
| class CPUDeviceContext : public DeviceContext { | ||
| public: | ||
| CPUDeviceContext(); | ||
| explicit CPUDeviceContext(CPUPlace place); | ||
| virtual ~CPUDeviceContext() {} |
There was a problem hiding this comment.
That line is useless.
* Since GPU is an async device by default. We should sync computation when Python invoke `run`. So Python can get the correct computation result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4339