Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code format] resume headers order of .cu file #43633

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

betterpig
Copy link
Contributor

@betterpig betterpig commented Jun 17, 2022

PR types

Others

PR changes

Others

Describe

Clang-format dest not consider .cu as main source files by default, so it sort the headers of .cu just by ASCIIbetical order.

  • resume the orders of .cu files following Google C++ style such like below:
    image
  • Config Clang-format to consider .cu file as main source file, and not sort headers cross different block, thant means you can seperate headers using block to avoid sorted

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 17, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql previously approved these changes Jun 20, 2022
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 previously approved these changes Jun 20, 2022
@betterpig betterpig dismissed stale reviews from luotao1 and chenwhql via 171421d June 20, 2022 12:44
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betterpig betterpig merged commit 829723f into PaddlePaddle:develop Jun 21, 2022
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants