Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove int pair #4374

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 25, 2017

No description provided.

Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@reyoung reyoung merged commit f8192f7 into PaddlePaddle:develop Sep 25, 2017
@reyoung reyoung deleted the feature/remove_int_pair branch September 25, 2017 21:31
@@ -46,7 +40,6 @@ message OpDesc {
repeated int32 ints = 6;
repeated float floats = 7;
repeated string strings = 8;
repeated IntPair int_pairs = 9;
optional bool b = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在重构阶段对proto改动不会影响兼容性,为啥不把后面的number也改了呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants